Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more tracing around webhooks #3441

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

zepatrik
Copy link
Member

No description provided.

request/builder.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3441 (535e69a) into master (610c76d) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 535e69a differs from pull request most recent head 5d43e20. Consider uploading reports for the commit 5d43e20 to get more accurate results

@@            Coverage Diff             @@
##           master    #3441      +/-   ##
==========================================
+ Coverage   77.99%   78.00%   +0.01%     
==========================================
  Files         327      327              
  Lines       21591    21596       +5     
==========================================
+ Hits        16839    16846       +7     
+ Misses       3496     3494       -2     
  Partials     1256     1256              
Files Changed Coverage Δ
courier/http.go 55.55% <100.00%> (ø)
courier/sms.go 60.37% <100.00%> (ø)
request/builder.go 73.91% <100.00%> (+1.18%) ⬆️
selfservice/hook/web_hook.go 79.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

@zepatrik zepatrik marked this pull request as ready for review August 18, 2023 13:00
@zepatrik zepatrik requested review from aeneasr and hperl as code owners August 18, 2023 13:00
@zepatrik zepatrik merged commit 8bb0d1d into master Aug 18, 2023
@zepatrik zepatrik deleted the chore/more-webhook-tracing branch August 18, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant